Remove unused problem list view#107
Merged
Merged
Conversation
jgonggrijp
approved these changes
May 18, 2026
| qs = self.get_queryset() | ||
|
|
||
| if filters is not None: | ||
| qs = qs.filter(filters) |
Contributor
There was a problem hiding this comment.
You could also just filter qs by hidden=False if the current user lacks appropriate permissions (after merging #106). I don't have a strong opinion on the matter though. We can always revert this later if we feel we need a list endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the unused
list()method fromProblemView, probably from an earlier stage of development where we considered having a list. Everything seems to work perfectly without it.We even had a few tests for a 'list' view in
TestProblemViewPermissions. These keep working even after removing.list(), sinceModelViewSetprovides a default list method that simply returns the whole queryset. That is going to be a problem (see what I did there?) with the new 'hidden' feature on problems (#106).To simplify things, I propose overriding the default list method and returning 404 NOT FOUND. The tests for the list view can then also go.