field multivalues#354
Draft
jgonggrijp wants to merge 32 commits into
Draft
Conversation
more stuff, fewer abbreviations
use field.id as id, include field proper as separate attribute
started adding the actual tests
missing import, outfactor bnode(), more test logic
deduplicated string constants, missing spy management, moar tests
needed to take the keys of changed attributes
completed the tests, at least for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress solution for #293 that builds on top of the changes in #353. #353 should be merged first, after which this branch will be rebased on develop. For now, this exists as a draft PR purely to inform you that the work is ongoing.