Skip to content

[ENG-9903] Comment out users from sitemap #11479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cslzchen merged 2 commits into from
Dec 10, 2025
+14 −14
Merged

[ENG-9903] Comment out users from sitemap #11479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e8ca3e
comment out users from sitemap
bodintsov Dec 4, 2025
991ea9d
fix tests
bodintsov Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions osf_tests/test_generate_sitemap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ def all_included_links(self, user_admin_project_public, user_admin_project_priva
# Return urls of all fixtures
urls_to_include = [item['loc'] for item in settings.SITEMAP_STATIC_URLS]
urls_to_include.extend([
user_admin_project_public.url,
user_admin_project_private.url,
# user_admin_project_public.url,
# user_admin_project_private.url,
project_registration_public.url + 'overview',
project_preprint_osf.url + 'overview',
project_preprint_other.url + 'overview',
Expand Down
24 changes: 12 additions & 12 deletions scripts/generate_sitemap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,18 +169,18 @@ def generate(self):
progress.increment()
progress.stop()

# User urls
objs = OSFUser.objects.filter(is_active=True).exclude(date_confirmed__isnull=True).values_list('guids___id', flat=True)
progress.start(objs.count(), 'USER: ')
for obj in objs:
try:
config = settings.SITEMAP_USER_CONFIG
config['loc'] = urljoin(settings.DOMAIN, f'/{obj}/')
self.add_url(config)
except Exception as e:
self.log_errors('USER', obj, e)
progress.increment()
progress.stop()
# # User urls
# objs = OSFUser.objects.filter(is_active=True).exclude(date_confirmed__isnull=True).values_list('guids___id', flat=True)
# progress.start(objs.count(), 'USER: ')
# for obj in objs:
# try:
# config = settings.SITEMAP_USER_CONFIG
# config['loc'] = urljoin(settings.DOMAIN, f'/{obj}/')
# self.add_url(config)
# except Exception as e:
# self.log_errors('USER', obj, e)
# progress.increment()
# progress.stop()

# AbstractNode urls (Nodes and Registrations, no Collections)
objs = (AbstractNode.objects
Expand Down
Loading