[ENG-8975] Redirect addons support #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsemets
previously approved these changes
Oct 22, 2025
futa-ikeda
changed the title
Contributor
Author
|
Needs to be released in tandem with this GV feature: CenterForOpenScience/gravyvalet#335 |
brianjgeiger
changed the base branch from
feature/pbs-25.02
to
feature/pbs-25.04
Contributor
|
@futa-ikeda Looks like there are some conflicts that need resolving. |
futa-ikeda
changed the title
nsemets
reviewed
Nov 18, 2025
| label: 'settings.addons.categories.otherServices', | ||
| value: AddonCategory.EXTERNAL_REDIRECT_SERVICES, | ||
| }, | ||
| // TODO: add this after feature flag gravy_redirect is either turned on for everyone or removed |
Collaborator
There was a problem hiding this comment.
Will it be added in near future?
Contributor
Author
There was a problem hiding this comment.
This should be addressed once we have deployed this to production and have confirmed with our external partners that things are working as expected for them on the production environment. I will make a separate ticket in Jira to clean up this feature-flagging logic
Contributor
Author
There was a problem hiding this comment.
Jira ticket to remove feature flag logic is ENG-9787
nsemets
approved these changes
Nov 18, 2025
nsemets
previously approved these changes
Nov 18, 2025
nsemets
previously approved these changes
Nov 19, 2025
nsemets
approved these changes
Dec 10, 2025
futa-ikeda
merged commit a4bb706
into
CenterForOpenScience:feature/pbs-25-24
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
gravy__redirectfeature flagScreenshot(s)
If you have the feature flag
gravy_redirectactive, you will see the option to view redirect services from GravyValet, otherwise this page will not look any differentWhen clicking into a redirect service's addon card, the Addons Terms page has been updated to show "Go to {ServiceName}" button, which should open a popup window that will take users to the URL shown at the bottom of the screen, as well as a link in the description that will take user to the same place in case the popup window is blocked
Side Effects
QA Notes
gravy_redirect. I've hidden it behind a waffle flag for a couple reasons 1) so we don't have to synchronize this too closely with the GravyValet release that is needed for this feature, and 2) so we can keep this feature turned off for everyone except COS and DataPipe maintainers when it is released to production. This way, the DataPipe team will be able to check for any issues on their end, before we release it to the general public by switching that waffle-flag on for everyone.