-
Notifications
You must be signed in to change notification settings - Fork 6
PHP 8.4 autofixes (nullsafe logger, container share API, path … #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…separators, typed returns, route methods fix, helpers env unquote)
…docs across core files
supercid
reviewed
Aug 21, 2025
supercid
reviewed
Aug 21, 2025
supercid
reviewed
Aug 21, 2025
supercid
reviewed
Aug 21, 2025
supercid
reviewed
Aug 21, 2025
supercid
reviewed
Aug 21, 2025
supercid
approved these changes
Aug 21, 2025
- Added proper type declarations to all class properties across the codebase - Updated property docblocks with proper @var annotations - Fixed property types in Core, Cache, Database, Helpers, Factories, and Classes - Improved code quality and IDE support with strict typing - All properties now have explicit types: string, int, bool, array, etc. - Enhanced type safety and code documentation
- Completely rewrote Configuration.md with JSON-based config structure - Completely rewrote Routing.md with SPIN-specific routing patterns - Completely rewrote Middleware.md with actual SPIN middleware structure - Completely rewrote Security.md with SPIN security patterns - All docs now based on spin-skeleton examples instead of generic patterns
- Replace outdated PHP array examples with correct JSON configuration - Update project structure to match spin-skeleton layout (src/app, src/public) - Fix routing examples to show actual SPIN JSON route configuration - Update controller examples to use SPIN's handleGET() pattern - Fix middleware examples to use SPIN's initialize() and handle() methods - Update web server configuration paths to use src/public - Add missing security features (JWT, Rate Limiting) - Reorganize documentation links to match actual available docs
- Fix PSR-7 compatibility issues in helper functions - Replace Laravel-style methods with proper PSR-7 Request methods - Fix queryParam, postParam, and cookieParam functions - Fix MIME content type function return types - Add comprehensive test suite for all global helper functions - Test coverage for env, app, config, container, logger functions - Test coverage for request parameter functions (query, post, cookie) - Test coverage for response functions (redirect, response, responseJson, etc.) - Test coverage for utility functions (getClientIp, generateRefId, etc.) - Resolve conflicts with built-in PHP mime_content_type function
- Add missing test configuration files (config-unittest.json, config-dev.json) - Set test environment to 'unittest' in bootstrap.php - Fix cache configuration to prevent 'Cache class does not exist' errors - Fix generateRefId test timing issue - Ensure proper test environment setup for GitHub Actions
- Fix withHeader() method calls to handle both array and string values - Ensure proper type casting for header values to prevent PSR-7 v2 compatibility issues - Fix applies to redirect(), response(), and other response helper functions - Resolves type mismatch errors with GuzzleHttp 7.x and PSR-7 v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…separators, typed returns, route methods fix, helpers env unquote)