Open
Conversation
add system command in R to force install of old version of tensorflow. Add line to check-R-notebooks.yml to add libpng-dev which is required for png library in R
Update DoubleML...BERT.ipynb and r_dml...ownership.irnb to fixed tensorflow version.
Remove calls to DoubleML in r-dml-401k.irnb which depend on mlr3 and not available in current R version. (Version with DoubleML moved to Old) Update check-R-notebooks.yml to install libfontconfig1-dev which is required for systemfonts package used by daggity
vsyrgkanis
requested changes
Feb 6, 2025
Collaborator
There was a problem hiding this comment.
Why did the whole dml401k notebook need to change?
Collaborator
There was a problem hiding this comment.
Similarly for this one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to notebooks that use NN's to call old versions of tensorflow to maintain compatibility. Update other outdated notebooks in PM4 and PM5.
Update to check-R-notebooks.yml to install libraries on ubuntu which are needed for various R packages.