Skip to content

Fix admin behat tests#6111

Merged
dmetzner merged 1 commit intodevelopfrom
admin-fix
Jan 21, 2026
Merged

Fix admin behat tests#6111
dmetzner merged 1 commit intodevelopfrom
admin-fix

Conversation

@dmetzner
Copy link
Copy Markdown
Collaborator

Fix usage of php unit Assertions in behat


Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing (CI), if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Ask for a code reviewer
  • Check that your pull request has been successfully deployed to https://web-test-1.catrob.at/

Additional Description

TODO: Add additional information that is not in your commit-message here

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 45.94595% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.98%. Comparing base (90a377e) to head (b13305f).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...esting/Behat/Context/RefreshEnvironmentContext.php 0.00% 10 Missing ⚠️
.../Projects/SpecialProjects/FeaturedProjectAdmin.php 0.00% 9 Missing ⚠️
...m/Testing/Behat/Context/CatrowebBrowserContext.php 94.44% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6111      +/-   ##
=============================================
+ Coverage      46.97%   49.98%   +3.01%     
- Complexity      7474     7481       +7     
=============================================
  Files            722      722              
  Lines          24071    24100      +29     
=============================================
+ Hits           11307    12047     +740     
+ Misses         12764    12053     -711     
Flag Coverage Δ
behat 47.68% <45.94%> (+3.11%) ⬆️
phpunit 10.18% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Fix usage of php unit Assertions in behat
@dmetzner dmetzner merged commit 351c61c into develop Jan 21, 2026
44 of 47 checks passed
@dmetzner dmetzner deleted the admin-fix branch April 9, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant