Skip to content

IDE-262: Confirmation dialog to be shown before deleting#5131

Open
Berend27 wants to merge 5 commits intoCatrobat:developfrom
Berend27:IDE-262-confirmation-diaglog
Open

IDE-262: Confirmation dialog to be shown before deleting#5131
Berend27 wants to merge 5 commits intoCatrobat:developfrom
Berend27:IDE-262-confirmation-diaglog

Conversation

@Berend27
Copy link
Copy Markdown
Contributor

@Berend27 Berend27 commented Jan 12, 2026 •
edited by dorianpercic
Loading

I created a confirmation dialog to be shown before deleting. This is for the ticket IDE-262.
https://catrobat.atlassian.net/browse/IDE-262

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@ratschillerp ratschillerp added the Active Member Tickets that are assigned to members that are still currently active label Jan 12, 2026
Frajhamster
Frajhamster requested changes Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Frajhamster Frajhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are existing tests which need to be updated, such as:

  • Catroid\catroid\src\androidTest\java\org\catrobat\catroid\uiespresso\ui\fragment\DeleteLookTest.java
  • Catroid\catroid\src\androidTest\java\org\catrobat\catroid\uiespresso\ui\fragment\DeleteSoundTest.java

And maybe even more, which are affected by your changes, please test it locally and if they fail, update the tests.

Frajhamster
Frajhamster reviewed Jan 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Frajhamster Frajhamster left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Please also squash your commits into one, by using "git rebase", you can check how to do this by googling or consulting the almighty AI.

@Berend27 Berend27 force-pushed the IDE-262-confirmation-diaglog branch from 5cb2a93 to 65922cd Compare January 25, 2026 21:11
@Berend27
Copy link
Copy Markdown
Contributor Author

Berend27 commented Jan 25, 2026

Changes look good. Please also squash your commits into one, by using "git rebase", you can check how to do this by googling or consulting the almighty AI.

Fertig, danke.

github-advanced-security[bot]
github-advanced-security AI found potential problems Jan 25, 2026
View reviewed changes
Comment thread ...droidTest/java/org/catrobat/catroid/uiespresso/ui/fragment/SpriteListFragmentNoObjectTest.kt Fixed
Comment thread ...oidTest/java/org/catrobat/catroid/uiespresso/ui/fragment/SpriteListFragmentWithObjectTest.kt Fixed
Comment thread catroid/src/main/java/org/catrobat/catroid/ui/dialogs/DeleteConfirmDialog.kt Fixed
Comment thread catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/fragment/SpriteListFragment.kt Fixed
github-advanced-security[bot]
github-advanced-security AI found potential problems Jan 25, 2026
View reviewed changes
Copy link
Copy Markdown

@github-advanced-security github-advanced-security AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkstyle found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

github-advanced-security[bot]
github-advanced-security AI found potential problems Jan 25, 2026
View reviewed changes
Comment thread catroid/src/main/res/layout/dialog_confirm_delete.xml Fixed
Comment thread catroid/src/main/java/org/catrobat/catroid/ui/dialogs/DeleteConfirmDialog.kt Fixed
Comment thread catroid/src/main/res/layout/dialog_confirm_delete.xml Fixed
Comment thread catroid/src/main/res/layout/dialog_confirm_delete.xml Fixed
github-advanced-security[bot]
github-advanced-security AI found potential problems Feb 2, 2026
View reviewed changes
Comment thread catroid/src/main/java/org/catrobat/catroid/ui/dialogs/DeleteTarget.kt Fixed
Comment thread catroid/src/main/java/org/catrobat/catroid/ui/dialogs/DeleteTarget.kt Fixed
@Berend27 Berend27 force-pushed the IDE-262-confirmation-diaglog branch from dd1136a to 8f19e09 Compare February 2, 2026 17:01
@Berend27 Berend27 force-pushed the IDE-262-confirmation-diaglog branch from 0a2e316 to c7e55d1 Compare February 2, 2026 17:33
github-advanced-security[bot]
github-advanced-security AI found potential problems Feb 9, 2026
View reviewed changes
Comment thread catroid/src/main/res/layout/dialog_confirm_delete.xml Fixed
@dorianpercic
Copy link
Copy Markdown
Contributor

dorianpercic commented Feb 12, 2026

@Berend27 Can you please update the PR Title to include the ticket number and the PR description with the JIRA Link? Thanks! :)

@Berend27 Berend27 changed the title confirmation dialog to be shown before deleting IDE-262: Confirmation dialog to be shown before deleting Feb 14, 2026
@Berend27
Copy link
Copy Markdown
Contributor Author

Berend27 commented Feb 14, 2026

@Berend27 Can you please update the PR Title to include the ticket number and the PR description with the JIRA Link? Thanks! :)

Alright done. : )

@dorianpercic dorianpercic self-requested a review February 15, 2026 09:02
dorianpercic
dorianpercic requested changes Feb 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dorianpercic dorianpercic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the PR with git pull upstream develop --rebase and resolve the merge conflicts.

@Berend27
Copy link
Copy Markdown
Contributor Author

Berend27 commented Mar 2, 2026

Please rebase the PR with git pull upstream develop --rebase and resolve the merge conflicts.

done

@Berend27 Berend27 closed this Mar 2, 2026
@Berend27 Berend27 reopened this Mar 2, 2026
@Berend27
Copy link
Copy Markdown
Contributor Author

Berend27 commented Mar 2, 2026

Changes look good. Please also squash your commits into one, by using "git rebase", you can check how to do this by googling or consulting the almighty AI.

done

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 2, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.9% Duplication on New Code

See analysis details on SonarQube Cloud

@Berend27
Copy link
Copy Markdown
Contributor Author

Berend27 commented Mar 2, 2026

There are existing tests which need to be updated, such as:

* Catroid\catroid\src\androidTest\java\org\catrobat\catroid\uiespresso\ui\fragment\DeleteLookTest.java

* Catroid\catroid\src\androidTest\java\org\catrobat\catroid\uiespresso\ui\fragment\DeleteSoundTest.java

And maybe even more, which are affected by your changes, please test it locally and if they fail, update the tests.

done, thanks for checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frajhamster Frajhamster Frajhamster requested changes

@dorianpercic dorianpercic dorianpercic requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Berend27 @dorianpercic @Frajhamster @github-advanced-security @ratschillerp