IDE-295 Refactor SoundRecorder files to Kotlin #5124
Conversation
reichli
added
the
Active Member
dorianpercic
force-pushed
the
IDE-295
branch
from
2dd02ff to
9a538e5
Compare
|
Rebased PR. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| @Throws(IOException::class, RuntimeException::class) | ||
| fun start() { |
Check warning
Code scanning / detekt
Restrict the number of throw statements in methods. Warning
| recorder.start() | ||
| isRecording = true | ||
| } catch (e: IllegalStateException) { | ||
| throw e |
Check warning
Code scanning / detekt
Do not rethrow a caught exception of the same type. Warning
| isRecording = true | ||
| } catch (e: IllegalStateException) { | ||
| throw e | ||
| } catch (e: RuntimeException) { |
Check warning
Code scanning / detekt
The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled. Warning
| } catch (e: IllegalStateException) { | ||
| throw e | ||
| } catch (e: RuntimeException) { | ||
| throw e |
Check warning
Code scanning / detekt
Do not rethrow a caught exception of the same type. Warning
| } catch (_: RuntimeException) { | ||
| Log.d( | ||
| TAG, ("Note that a RuntimeException is intentionally " | ||
| + "thrown to the application, if no valid audio/video data " |
Check warning
Code scanning / detekt
Checks if condition chaining is wrapped right Warning
| + "is called immediately after start(). The failure lets the application " | ||
| + "take action accordingly to clean up the output file " | ||
| + "(delete the output file, for instance), since the output file " | ||
| + "is not properly constructed when this happens.") |
Check warning
Code scanning / detekt
Checks if condition chaining is wrapped right Warning
| } catch (e: IllegalStateException) { | ||
| Log.e(TAG, "Error recording sound (Other recorder running?).", e) | ||
| ToastUtil.showError(this, R.string.soundrecorder_error) | ||
| } catch (e: RuntimeException) { |
Check warning
Code scanning / detekt
The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled. Warning
|
|
||
| @Test | ||
| fun testMaxAmplitudeDelegatesToMediaRecorder() { | ||
| val expectedAmplitude = 12345 |
Check warning
Code scanning / detekt
Report missing or invalid underscores in base 10 numbers. Numeric literals should be underscore separated to increase readability. Warning test
| // Create a file (not directory) at the path where we need a directory | ||
| // Then try to create a subdirectory inside it - mkdirs() will fail | ||
| val blockingFile = File(tempFolder.root, "blocker") | ||
| blockingFile.createNewFile() // Create a FILE named "blocker" |
Check warning
Code scanning / detekt
Reports multiple space usages Warning test
| // "blocker" is a file, not a directory | ||
| val invalidPath = File(File(blockingFile, "subdir"), "test.m4a").absolutePath | ||
| val invalidRecorder = SoundRecorder(invalidPath, mockRecorder) | ||
| invalidRecorder.start() // Should throw IOException: "Path to file could not be created." |
Check warning
Code scanning / detekt
Reports multiple space usages Warning test
|
4 participants
Refactored the files
org.catrobat.catroid.soundrecorder.RecordButton,org.catrobat.catroid.soundrecorder.SoundRecorder, andorg.catrobat.catroid.soundrecorder.SoundRecorderActivityfrom Java to Kotlin. Created a Unit-Test for SoundRecorder in addition to existing Integration-Tests. Added Dependency for MockK and used it to fix the test inorg.catrobat.catroid.test.formulaeditor.SensorHandlerTest.https://catrobat.atlassian.net/browse/IDE-295
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.