-
Notifications
You must be signed in to change notification settings - Fork 773
IDE-264 Updated all related dependencies and migrated to targetSDKVersion 34 #5111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
When the NEW Update Will Come 🥹😣
|
|
@TIMEXYZO Soon enough 😉 |
dorianpercic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also remove the buildToolsVersion = "33.0.2" statement in the catroid/build.gradle file, as this is not needed anymore and is part of the AGP.
| buildscript { | ||
| ext.kotlin_version = '1.6.21' | ||
| ext { | ||
| agp_version1 = '8.6.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just use agp_version instead of agp_version1.
| android.enableJetifier=true | ||
|
|
||
| org.gradle.caching=false | ||
| android.nonTransitiveRClass=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our app is basically a single module app, so we do not need to switch this off. If we migrate our app to a multi module architecture, it will significantly improve the build process if this is set to true, which happens by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Furthermore, we need to change the Java Version in the following places to Java 17:
- https://github.com/khaledelnaggar/Catroid/blob/IDE-264/catroid/build.gradle#L260
- https://github.com/khaledelnaggar/Catroid/blob/IDE-264/catroid/build.gradle#L570
This change will break the build on the CI and also the PowerMock module is not supported anymore, so the Unit Tests need to be adjusted as well, which is targeted in this epic.
|
@khaledelnaggar If possible, please always include a TL;DR in the PR description and add the JIRA link 🙂 |



Please enter a short description of your pull request and add a reference to the Jira ticket.
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.