Support cache_classes: true descendants filtering#54
Merged
Conversation
nertzy
force-pushed
the
descendants-tracking-active-record-cache_classes
branch
2 times, most recently
from
0260baf to
3b24d3e
Compare
nertzy
changed the title
nertzy
force-pushed
the
descendants-tracking-active-record-cache_classes
branch
from
3b24d3e to
cf1523f
Compare
When cache_classes is true, we can no longer rely on the Active Support dependencies tracker, so we use our own separate tracker to filter out destroyed with_model models from Class#descendants and Class#subclasses. Fixes #35
nertzy
force-pushed
the
descendants-tracking-active-record-cache_classes
branch
from
cf1523f to
386503f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cache_classes is true, we can no longer rely on the Active Support dependencies tracker, so we use our own separate tracker to filter out destroyed with_model models from Class#descendants and Class#subclasses.
Fixes #35