Skip to content

Don't load columns from tables in other schemas #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pjungwir wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Don't load columns from tables in other schemas #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b30acc
Don't load columns from tables in other schemas
pjungwir Jun 6, 2016
47666fa
Preserve old behavior watching all schemas unless user says otherwise
pjungwir Jun 7, 2016
4776cc8
Fix strange capitalization
pjungwir Jun 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/generators/pg_audit_log/templates/lib/tasks/pg_audit_log.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace :pg_audit_log do
end

puts "Installing audit_changes() function..."
PgAuditLog::Function.install
PgAuditLog::Function.install(ENV['PG_AUDIT_LOG_SCHEMA'].presence)

puts "Installing all audit log triggers... "
PgAuditLog::Triggers.install
Expand Down
5 changes: 3 additions & 2 deletions lib/pg_audit_log/function.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ def user_unique_name_temporary_function(username)
end
end

def install
def install(only_audit_schema=nil)
schema_restriction = only_audit_schema ? "AND table_schema = '#{only_audit_schema}'" : ""
execute <<-SQL
CREATE OR REPLACE PROCEDURAL LANGUAGE plpgsql;
CREATE OR REPLACE FUNCTION #{name}() RETURNS trigger
Expand Down Expand Up @@ -75,7 +76,7 @@ def install
INTO primary_key_column USING TG_RELNAME;
primary_key_value := NULL;

FOR col IN SELECT * FROM information_schema.columns WHERE table_name = TG_RELNAME LOOP
FOR col IN SELECT * FROM information_schema.columns WHERE table_name = TG_RELNAME #{schema_restriction} LOOP
new_value := NULL;
old_value := NULL;
column_name := col.column_name;
Expand Down