Add course registration resources page #594
Merged
Merged
Conversation
Contributor
|
🎊 PR Preview 4c64c64 has been successfully built and deployed to https://CarletonComputerScienceSociety-website-build_preview-pr-594.surge.sh 🕐 Build time: 0.014s
🤖 By surge-preview |
MathyouMB
reviewed
Jun 14, 2025
Comment on lines
+13
to
+15
| related: | ||
| - first-year-course-selection | ||
| - making-your-perfect-schedule |
Member
There was a problem hiding this comment.
non blocking:
I feel like we should also be making this general enough you could relate any resource type: faq, article, etc.
The ideal structure would be some kind of list that allows for all resource types polymorphicly so you can intermangle faqs and articles
"related": [
{
"type": "faq"
"id": "what-is-a-breadth-elective"
},
{
"type": "article"
"id": "first-year-course-selection"
}
]
Do we need this right now, no.
But it's weird that one resource type is doing this one way, and the other is doing it's on thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.