Rework regions to use SportBukkit math features, implement point regions #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| coords = Vectors.getCoordinates(maxValue); | ||
| if (coords == null || coords.size() != 2) { | ||
| coords = Numbers.parseCoordinates(maxValue); | ||
| if (coords == null || coords[2] != 2) { |
Contributor
There was a problem hiding this comment.
Should be coords.length != 2, not coords[2] != 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@iEli2tyree011 and @Pablete1234
If you guys could check this out ad tell me what you think, I want this.
A big part of this is implementing the point regions. Based on docs, there seems to really be two types of point regions, and they are broken up accordingly.
I also tweaked some of the util classes.