security: fix infinite loops, unsafe fromJust, naming collisions, and…#4
Open
kanyuku wants to merge 2 commits intoCardanoHubNBO:mainfrom
Open
security: fix infinite loops, unsafe fromJust, naming collisions, and…#4kanyuku wants to merge 2 commits intoCardanoHubNBO:mainfrom
kanyuku wants to merge 2 commits intoCardanoHubNBO:mainfrom
Conversation
… remove blanket warning suppressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes six security and stability issues in the e2e-tests framework, including an infinite polling loop in waitForTxIdAtAddress and several fromJust panics that could trigger runtime crashes during era mismatches. It also resolves a critical naming collision in
V_1_1.hs
to prevent silent Plutus version mismatches and removes project-wide GHC warning suppressions in 41 files to restore compile-time exhaustiveness checks. These changes collectively harden the test suite against denial-of-service hangs, improve error observability in CI, and enforce stricter type safety across the cryptographic script modules.