Log a warning when timer left in zombie state#98
Open
HunterZ wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a plugin calls
timer.In()ortimer.Once()beforeOnServerInitialized(), Carbon will never schedule it, leaving it in a zombie state forever.This change at least adds a warning so that plugin developers and sever owners have visibility into this zombie timer state.
Examples of this happening in the wild include Discord Chat by MJSU (breaks server booting messages) and Zone Manager by k1lly0u (probably harmless since it seems to be the result of
OnPlayerSleep()firing for non-players).