fix(ReverseProxy): handle forwarding#510
Open
Betree wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider turning
service_subdomain_regex/0into a module attribute (e.g.@service_subdomain_regex) to avoid recompiling the same regex on every call torouting_host/1andget_domain_from_host/1. - In
routing_host/1, you currently preferconn.hostwhenever it matches the service subdomain regex; if an internal host ever accidentally matches that pattern (e.g.rest.internal.local),x-forwarded-hostwill be ignored—consider tightening the condition or explicitly preferring a validx-forwarded-hostwhen present and different fromconn.host.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider turning `service_subdomain_regex/0` into a module attribute (e.g. `@service_subdomain_regex`) to avoid recompiling the same regex on every call to `routing_host/1` and `get_domain_from_host/1`.
- In `routing_host/1`, you currently prefer `conn.host` whenever it matches the service subdomain regex; if an internal host ever accidentally matches that pattern (e.g. `rest.internal.local`), `x-forwarded-host` will be ignored—consider tightening the condition or explicitly preferring a valid `x-forwarded-host` when present and different from `conn.host`.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
2575f1b to
347d04c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.