-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(desktop): restore last confirmed capture area when reopening selector #1872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ManthanNimodiya
wants to merge
10
commits into
CapSoftware:main
Choose a base branch
from
ManthanNimodiya:fix/capture-area-restore-last-selection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+77
−24
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3539107
fix(desktop): restore last confirmed capture area when reopening sele…
ManthanNimodiya d931863
fix(desktop): restore last confirmed capture area when reopening sele…
ManthanNimodiya 146e06f
fix(desktop): address review — untrack screenId in effect, fallback i…
ManthanNimodiya 63869d9
fix(desktop): simplify screenId to reactive memo, fix hasStoredSelect…
ManthanNimodiya 0f2d5ba
fix(desktop): guard hasStoredSelection area check against empty bound…
ManthanNimodiya e1557b2
fix(desktop): skip degenerate area bounds in effectiveInitialBounds t…
ManthanNimodiya 4de6f6d
fix(desktop): check lastSelectedBounds before captureTarget fallback …
ManthanNimodiya dc13f2b
fix(desktop): zero captureTarget bounds on reset to prevent fallback …
ManthanNimodiya 9ed93e9
fix(desktop): prefer captureTarget bounds over lastSelectedBounds in …
ManthanNimodiya 842d38d
fix(desktop): move cropperRef.reset after state clear, switch capture…
ManthanNimodiya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -234,6 +234,27 @@ function Inner() { | |||||||||||||||||||||||||||||||
| CropBounds | undefined | ||||||||||||||||||||||||||||||||
| >(undefined); | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| const effectiveInitialBounds = createMemo<CropBounds | undefined>(() => { | ||||||||||||||||||||||||||||||||
| const explicit = initialAreaBounds(); | ||||||||||||||||||||||||||||||||
| if (explicit !== undefined) return explicit; | ||||||||||||||||||||||||||||||||
| const target = options.captureTarget; | ||||||||||||||||||||||||||||||||
| if ( | ||||||||||||||||||||||||||||||||
| target.variant === "area" && | ||||||||||||||||||||||||||||||||
| params.displayId && | ||||||||||||||||||||||||||||||||
| target.screen === params.displayId | ||||||||||||||||||||||||||||||||
| ) { | ||||||||||||||||||||||||||||||||
| const { width, height } = target.bounds.size; | ||||||||||||||||||||||||||||||||
| if (width <= 1 || height <= 1) return undefined; | ||||||||||||||||||||||||||||||||
| return { | ||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If
Suggested change
|
||||||||||||||||||||||||||||||||
| x: target.bounds.position.x, | ||||||||||||||||||||||||||||||||
| y: target.bounds.position.y, | ||||||||||||||||||||||||||||||||
| width, | ||||||||||||||||||||||||||||||||
| height, | ||||||||||||||||||||||||||||||||
| }; | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
| return undefined; | ||||||||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| createEffect(() => { | ||||||||||||||||||||||||||||||||
| const target = options.captureTarget; | ||||||||||||||||||||||||||||||||
| if ( | ||||||||||||||||||||||||||||||||
|
|
@@ -725,7 +746,7 @@ function Inner() { | |||||||||||||||||||||||||||||||
| () => isInteracting() || isActiveDisplay(), | ||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||
| const shouldShowSelectionHint = createMemo(() => { | ||||||||||||||||||||||||||||||||
| if (initialAreaBounds() !== undefined) return false; | ||||||||||||||||||||||||||||||||
| if (effectiveInitialBounds() !== undefined) return false; | ||||||||||||||||||||||||||||||||
| if (!isActiveDisplay()) return false; | ||||||||||||||||||||||||||||||||
| const bounds = crop(); | ||||||||||||||||||||||||||||||||
| return bounds.width <= 1 && bounds.height <= 1 && !isInteracting(); | ||||||||||||||||||||||||||||||||
|
|
@@ -1146,7 +1167,7 @@ function Inner() { | |||||||||||||||||||||||||||||||
| ref={cropperRef} | ||||||||||||||||||||||||||||||||
| onInteraction={setIsInteracting} | ||||||||||||||||||||||||||||||||
| onCropChange={setCrop} | ||||||||||||||||||||||||||||||||
| initialCrop={() => initialAreaBounds() ?? CROP_ZERO} | ||||||||||||||||||||||||||||||||
| initialCrop={() => effectiveInitialBounds() ?? CROP_ZERO} | ||||||||||||||||||||||||||||||||
| showBounds={isValid()} | ||||||||||||||||||||||||||||||||
| aspectRatio={aspect() ?? undefined} | ||||||||||||||||||||||||||||||||
| snapToRatioEnabled={snapToRatioEnabled()} | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.