Open
Conversation
Forward solvers only use hybrid policies, while adjoint solvers differ. May delete or omdify yet in future.
Added MC tallies (or close) to RR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous PR was quite stale with all of the things that had been happening in RR meanwhile.
We have a new RR implementation which makes the physics packages much leaner. It should be relatively easy to extend to different types of RR solver. At the most we support flat and linear sources with isotropic scattering. Anisotropic should be ok to add. We also support eigenvalue and fixed source calculations, with isotropic material sources. This also supports adjoint calculations and the production of weight windows by FW-CADIS.
RR also now supports MC tallying, which should make it easier to produce results. This required the addition of a 'rayClerk', which is mostly a very trimmed down collisionClerk, with less cross section logic.
I also made physics packages optionally quiet to allow for integration tests, which RR has.