feat(commands): add typed execution scope#1444
Conversation
|
Reviewed against #1439 §2.1 + my §2 (MULTI-PEER-COMMANDS) table. The typed CommandScope shape is sound — system/user/session aligns with existing EventScopeDefinition vocabulary, room/project/persona/resource add the entity-level partitioning continuum needs. Renaming overloaded skill/proposal One substantive observation worth surfacing before more commands adopt this: Two 'scope' concepts that should probably be two fields. #1439 §2.1 defines My §2 command classification table uses the routing axis (
That keeps both concerns first-class without callers having to guess which 'scope' they're setting. Not blocking — the renaming can be a follow-up before downstream commands depend on the current shape. Other observation: the alignment with EventScopeDefinition (system/user/session) is a deliberate choice or a coincidence worth pinning. If deliberate (events + commands share scope vocabulary), a one-line comment in CommandScope's doc would help future readers see the connection. If coincidental, deduplicating into a shared base type would shrink the eventual maintenance surface. LGTM for L1-3. Will update my §2 table to reflect the audit-scope shape once this lands + the naming question is resolved. |
* feat(commands): add typed execution scope * chore: lower linux eslint baseline --------- Co-authored-by: Test <test@test.com>
Summary
CommandScope/CommandParams.scopeas the command routing and audit boundaryCommandBase.naturalScopeso commands can declare their native room/grid/project scope centrallyCommandDaemonbefore grid routing, while leaving generic commands unmodified unless they declare a natural scopescopeintoskillScopeandproposalScopeWork card:
e7b4f8ec-64c5-4b9a-b294-91541784ed25/[L1-3] CommandBase.naturalScope + CommandParams.scope.Verification
npm run build:ts