refactor(ai/should-respond): delete dead protected helpers — Rust path owns gating now#1428
Merged
Merged
Conversation
…h owns gating now After #1421 + #1424 + the should-respond oxidizer wave, the `AIShouldRespondCommand` parent class's protected helpers (`buildGatingInstruction`, `parseGatingResponse`) became dead code. The Server impl now delegates to `RustCoreIPCClient.cognitionShouldRespond` which routes through the Rust `cognition/should_respond.rs::evaluate_gating` path; nothing calls the TS helpers anymore. Per Joel's zero-users no-migration-ceremony directive: delete now, not "deprecate for follow-up." Single PR. ## Diff - AIShouldRespondCommand.ts: -172 LOC (kept 7-LOC shell for inheritance) ## What gets deleted - `protected buildGatingInstruction(params): string` (~95 LOC) — Rust `cognition/should_respond.rs::build_gating_prompt` is the prompt source of truth. - `protected parseGatingResponse(aiText): Partial<...>` (~65 LOC) — Rust `cognition/should_respond.rs::parse_gating_response` is the parser source of truth. ## What stays - Class shell (`AIShouldRespondCommand extends CommandBase`) — still the inheritance base for both `AIShouldRespondServerCommand` and `AIShouldRespondBrowserCommand`. - `static readonly commandName = 'ai/should-respond'` — used by the command registry to discover the command name. ## Verification - `npm run build:ts` — clean (no remaining references to deleted helpers). - `grep` for callers of the deleted methods: zero (only the now-deleted definitions themselves matched in the prior wave). - ESLint baseline check: no change (the deleted methods were lint-clean). ## Refs - continuum#1421 (AIShouldRespondServerCommand delegation that orphaned these helpers) - Joel 2026-05-18 19:44Z (zero-users, no migration ceremony → delete-loser-in-one-PR) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the should-respond oxidizer wave (#1421 + #1424 + parent #1248), the
AIShouldRespondCommandparent class's protected helpers (buildGatingInstruction,parseGatingResponse) became dead code. The Server impl delegates toRustCoreIPCClient.cognitionShouldRespond→ Rustcognition/should_respond.rs::evaluate_gating. Nothing calls the TS helpers.Per Joel's zero-users no-migration-ceremony directive: delete now, not "deprecate for follow-up."
Diff
AIShouldRespondCommand.ts: -172 LOC (kept 7-LOC shell for inheritance)What gets deleted
protected buildGatingInstruction(params)(~95 LOC) — Rustbuild_gating_promptis the prompt source of truthprotected parseGatingResponse(aiText)(~65 LOC) — Rustparse_gating_responseis the parser source of truthWhat stays
AIShouldRespondCommand extends CommandBase) — inheritance base for Server + Browser commandsstatic readonly commandName = 'ai/should-respond'— command registry discoveryVerification
npm run build:ts— clean (no remaining references to deleted helpers)grepfor callers of deleted methods: zeroRefs
🤖 Generated with Claude Code