Skip to content

fix(seed): await seedDatabase before SERVER_READY (closes Room-not-found race) #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joelteply merged 1 commit into from
May 4, 2026
Merged

fix(seed): await seedDatabase before SERVER_READY (closes Room-not-found race) #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions src/server/docker-entrypoint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,23 +31,10 @@ async function main(): Promise<void> {

console.log(`✅ Server ready (milestones: ${result.completedMilestones.join(' → ')})`);

// Auto-seed database if empty (first run).
// In-process via Commands.execute() — zero subprocess spawns.
// ~200MB instead of 2GB, <5 seconds instead of 30+.
setTimeout(async () => {
try {
const { seedDatabase } = await import('./seed-in-process');
const seeded = await seedDatabase();
if (seeded) {
console.log('✅ Database seeded');
} else {
console.log('✅ Database already seeded');
}
} catch (e: unknown) {
const msg = e instanceof Error ? e.message : String(e);
console.warn(`⚠️ Auto-seed: ${msg}`);
}
}, 5000);
// Seed runs synchronously inside SystemOrchestrator before SERVER_READY
// milestone fires (see SystemOrchestrator.ts). No duplicate seed here —
// the previous setTimeout(5000) raced the orchestrator's setTimeout(3000)
// and could re-enter findOrCreateRoom on a partially-committed table.

// Keep process alive — server event loop runs in background
}
Expand Down
34 changes: 17 additions & 17 deletions src/system/orchestration/SystemOrchestrator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1110,24 +1110,24 @@ export class SystemOrchestrator extends EventEmitter {

console.debug('✅ Server is ready');

// Auto-seed database if empty (first run or after data:clear).
// In-process via Commands.execute() — zero subprocess spawns, works in both
// Docker and bare metal. The old npm run data:seed approach spawns jtag CLI
// subprocesses that connect via WebSocket, which is fragile and slow.
setTimeout(async () => {
try {
const { seedDatabase } = await import('../../server/seed-in-process');
const seeded = await seedDatabase();
if (seeded) {
console.log('✅ Database seeded (in-process)');
} else {
console.log('✅ Database already seeded');
}
} catch (e: unknown) {
const msg = e instanceof Error ? e.message : String(e);
console.warn(`⚠️ Auto-seed failed: ${msg}`);
// Auto-seed database if empty BEFORE declaring SERVER_READY.
// Was setTimeout(3000) → fired-and-forget; orchestrator returned ready
// while seed was still running. carl-install-smoke probed chat/send 7-21s
// after install completed and intermittently hit "Room not found: general"
// because rooms hadn't landed yet. Awaiting seed here closes that race —
// by the time downstream sees SERVER_READY, rooms+personas exist.
try {
const { seedDatabase } = await import('../../server/seed-in-process');
const seeded = await seedDatabase();
if (seeded) {
console.log('✅ Database seeded (in-process)');
} else {
console.log('✅ Database already seeded');
}
}, 3000);
} catch (e: unknown) {
const msg = e instanceof Error ? e.message : String(e);
console.warn(`⚠️ Auto-seed failed: ${msg}`);
}

await milestoneEmitter.completeMilestone(
SYSTEM_MILESTONES.SERVER_READY,
Expand Down
Loading