fix(continuum-core/gpu): detect Vulkan via vulkaninfo (was missing entirely)#1039
Merged
Conversation
…tirely) detect_gpu() in memory_manager.rs only had Metal and CUDA branches. Vulkan was listed as a "supported path" in the panic message + Cargo features but never actually wired into detection. Result: every continuum-core-vulkan build panicked at boot with "No GPU detected" regardless of whether a Vulkan ICD was present (NVIDIA, mesa-radv, mesa-llvmpipe, etc). Caught live during Carl-Windows install retest of the vulkan variant on bigmama-1 (continuum-b69f, 2026-05-04): freshly-built continuum-core-vulkan:108bbc33d image had libvulkan1 + mesa-vulkan-drivers + vulkan-tools installed in the runtime stage, but the binary never asked the loader anything — it fell straight through detect_gpu()'s if-cuda-cfg → panic. Fix: add detect_vulkan() that mirrors detect_cuda's nvidia-smi subprocess approach. Calls vulkaninfo --summary (already in the runtime image via the vulkan-tools apt package), parses the first deviceName line. Works with any ICD: NVIDIA's loader on a GPU host, mesa-llvmpipe (software) on a no-/dev/dri runner like ubuntu-latest CI, mesa-radv on AMD, etc. Memory size is conservative (4 GiB) because vulkaninfo --summary doesn't reliably report device-local heap totals across all ICDs without pulling in `ash`. Real allocations go through the Vulkan loader at runtime via candle/llama.cpp's vulkan backend, so this number only seeds GpuMemoryManager's budget estimator. Unblocks: PR #1038 (drop core variant + default to vulkan) and #1035 (canary→main), both of which were stuck on the smoke gate that requires a vulkan binary to actually start. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detect_gpu had only Metal + CUDA branches, no Vulkan — every continuum-core-vulkan binary panicked at boot. Adds detect_vulkan() mirroring detect_cuda subprocess shape (vulkaninfo --summary, already in runtime image). Works with NVIDIA / mesa-radv / mesa-llvmpipe / any ICD. Unblocks PR #1038 and #1035.