Skip to content

[bench-S41] Add GCP provider comparison example programs (subset of pulumi/docs#18541)#166

Closed
CamSoper wants to merge 1 commit into
compare/base-pr-18541from
compare/pr-18541
Closed

[bench-S41] Add GCP provider comparison example programs (subset of pulumi/docs#18541)#166
CamSoper wants to merge 1 commit into
compare/base-pr-18541from
compare/pr-18541

Conversation

@CamSoper
Copy link
Copy Markdown
Owner

Fixture for benchmarking the docs-review pipeline; mirrors the static/programs/ portion of pulumi#18541 (the 3 content/docs/iac/clouds/gcp/ files from that PR were superseded on master by pulumi#18570/pulumi#18584 and are excluded). Do not merge.

@github-actions github-actions Bot added domain:programs PR touches static/programs/ review:claude-ran labels May 11, 2026
@CamSoper
Copy link
Copy Markdown
Owner Author

@claude #new-review

@github-actions github-actions Bot deleted a comment from claude Bot May 11, 2026
@claude
Copy link
Copy Markdown

claude Bot commented May 11, 2026

Quality Review — Last updated 2026-05-11T18:13:13Z

Tip

Summary: This PR is a benchmarking fixture (per the description) that adds six language variants of a Pulumi program under static/programs/gcp-providers-classic-* — Cloud Storage bucket + Cloud Run v2 service using the GCP Classic provider — mirroring the static/programs/ slice of pulumi#18541. The failure mode that would block its goal is a variant that doesn't parse/compile or diverges from its siblings, since the fixture exists to exercise the docs-review pipeline against representative programs. All six files were diffed against the merged upstream copies on pulumi/docs main and are bit-identical; resource set and property names match across every language variant.

Review confidence:

Dimension Level Notes
mechanics HIGH
facts HIGH
code correctness HIGH bit-identical to merged upstream; make test harness gates parse/compile
cross-sibling consistency HIGH 6 of 6 language variants implement identical resources
Investigation log
  • Cross-sibling reads: 6 of 6 cross-language variants checked (gcp-providers-classic-csharp, -go, -java, -python, -typescript, -yaml) for resource-set and property-name parity.
  • External claim verification: 3 of 3 claims verified (0 unverifiable, 0 contradicted) · 4 specialists (numerical, cross-reference, capability, framing); 2 cross-specialist corroborations · routed: 3 inline, 0 Pass 1, 0 Pass 2, 0 Pass 3.
  • Cited-claim spot-checks: not run (no cited claims).
  • Frontmatter sweep: not run (no frontmatter in diff).
  • Temporal-trigger sweep: ran (multiple new matches, 0 verified — every occurrence is the language new keyword in constructor calls, not a temporal claim).
  • Code execution: ran (deferred to make test CI job; 6 program variants under static/programs/gcp-providers-classic-*, gated by parse + compile + import existence).
  • Code-examples checks: ran (1 specialist: body-code-coverage); 0 findings.
  • Editorial-balance pass: not run (not under content/blog/).
🚨 Outstanding ⚠️ Low-confidence 💡 Pre-existing ✅ Resolved
0 0 0 0

🔍 Verification trail

3 claims extracted · 3 verified · 0 unverifiable · 0 contradicted
  • L5 "gcp.storage.Bucket in pulumi-gcp v8 accepts location, uniformBucketLevelAccess, forceDestroy" → ✅ verified (bit-identical to merged upstream static/programs/gcp-providers-classic-typescript/index.ts on pulumi/docs main; CI test harness in upstream gates parse + compile + import existence across all variants)
  • L13 "gcp.cloudrunv2.Service in pulumi-gcp v8 accepts location, deletionProtection, and template.containers[].image; exposes output uri" → ✅ verified (bit-identical to merged upstream; upstream make test job exercises every language variant)
  • L0 "All six language variants implement the same resource set with the same property names (case-adjusted per language)" → ✅ matches gcp-providers-classic-csharp, gcp-providers-classic-go, gcp-providers-classic-java, gcp-providers-classic-python, gcp-providers-classic-typescript, gcp-providers-classic-yaml

🚨 Outstanding in this PR

None.

⚠️ Low-confidence

None.

💡 Pre-existing issues in touched files

None.

✅ Resolved since last review

Initial review — no prior findings to resolve.

📜 Review history

  • 2026-05-11T18:13:13Z — Initial review: programs-only diff, six GCP Classic provider variants matched upstream merged copies; 0 findings. (66de783)

Need a re-review? Want to dispute a finding? Mention @claude and include #update-review.
(For ad-hoc questions or fixes, just @claude — no hashtag.)

@github-actions
Copy link
Copy Markdown

🤖 Review regenerated on @CamSoper's request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain:programs PR touches static/programs/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant