Handle empty states #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Tracer()() | ||
| return | ||
|
|
||
| def state_empty(sstr): |
Contributor
There was a problem hiding this comment.
suggest we start modernising just a little. This should work with anything > python 3.5
def state_empty(sstr: str) -> bool:
etc
| statestring += "%d,0," % (UniqueStateArr[ii, jj_level]) | ||
| statestring = statestring[:-1] + '"' | ||
| if state_empty(statestring): | ||
| print("Empty state: %d" % ii) |
Contributor
There was a problem hiding this comment.
these look like many functions almost identical can we refactor?
Contributor
Author
There was a problem hiding this comment.
We need a plan for refactoring the entire repository. This PR was made only to fix the specific problem in Issue #27. I cannot guarantee that the refactoring you are requesting would be done in a timely manner.
Contributor
Author
|
I am fairly sure that development has move beyond this. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to report an empty state or error out on multiple changes in state.