Add Config file ingestion for Hispec daemons #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikelangmayr
commented
Dec 17, 2025
mikelangmayr
commented
- Add YAML Config ingestion
- Update Kickoff daemon to use new daemon and new config files
- Support subsystem wide config files and single daemon config files
- support daemon specific properties
mikelangmayr
requested review from
Kupaianaha,
Yashvi-Sharma,
prkrtg and
scizen9
Kupaianaha
approved these changes
Dec 17, 2025
Collaborator
Kupaianaha
left a comment
Kupaianaha
left a comment
There was a problem hiding this comment.
Looks good, Thanks for the example, makes it much easier to fold into other daemons
prkrtg
approved these changes
Dec 17, 2025
Contributor
prkrtg
left a comment
prkrtg
left a comment
There was a problem hiding this comment.
LGTM, you would just need to rebase with main now since I merged the initial HispecDaemon template PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.