HSICS 80 FEI atc Filter Wheel Daemon #112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 19, 2025 14:18
…/hispec into HSICS-80-FEI-ND-filter-wheel-hsfei.atcfwheel
Kupaianaha
requested review from
Yashvi-Sharma,
mikelangmayr,
prkrtg and
scizen9
prkrtg
reviewed
Dec 5, 2025
| Args: come from the hsfei configuration file | ||
| """ | ||
| #on start set up the daemon from config and initialize device | ||
| config = configparser.ConfigParser() |
Contributor
There was a problem hiding this comment.
We should use the config parser built in libby, not a custom parsing
Collaborator
Author
There was a problem hiding this comment.
Does this mean that our config files will be in yaml or json format?
We should also finalize the structure of our config files. What I have implemented is something that would be 1 config file per group. Another way would be to have a config file per daemon but that would clutter each group with config files. I dont think the libby config parser handles things the I need.(primarily named pos)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.