Mike/add fits writer#101
Open
mikelangmayr wants to merge 7 commits into
Open
Conversation
Contributor
mikelangmayr
commented
May 15, 2026
mikelangmayr
commented
- add async FITS writer
- add output frame factory and hook it up
- make default expose mode override-able
prkrtg
reviewed
May 18, 2026
Collaborator
astronomerdave
left a comment
astronomerdave
left a comment
There was a problem hiding this comment.
We have a fits writer that @drriddle wrote and has been pretty successful for high-speed AO.
| this->controller->is_camera_mode = true; | ||
|
|
||
| std::string target = ArchonExposureMode::SINGLE; | ||
| std::string target = this->default_exposure_mode_name(); |
Collaborator
There was a problem hiding this comment.
If I ask for an exposure mode that doesn't exist then this will silently give me some other mode.
| if (!started_.load()) return ERROR; | ||
|
|
||
| // Cadence gate — skipped frames never enter the queue | ||
| if (cfg_.write_interval_ms > 0) { |
Collaborator
There was a problem hiding this comment.
I would put the decision to write outside of the fits writer, or else it's more than a fits writer. Camerad should make the decisions and once it gets to the fits queue, it's being written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.