Skip to content

fix #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
an-avocado wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ Imports:
glue,
stringr,
english
RoxygenNote: 7.1.2
Suggests:
testthat (>= 2.1.0)
Config/roxygen2/version: 8.0.0
4 changes: 2 additions & 2 deletions R/give_candygrams.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#'
#' @return A candy gram announcement
#'
#' @importFrom stringr str_detect str_to_title
#' @importFrom stringr str_detect str_to_title str_trim
#' @importFrom english as.english
#'
#' @export
Expand All @@ -30,7 +30,7 @@ give_candygrams <- function(person, number,
number <- str_to_title(as.english(number))


glue::glue("{number} for {person}.")
glue::glue("{number} for {person}. {extra_message}") |> str_trim(side = "both")



Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,5 +105,5 @@ give_candygrams("Glen Coco", 4)

``` r
give_candygrams("Gretchen Weiners", 4)
#> [1] "None for Grethen Weiners."
#> None for Gretchen Weiners.
```