Conversation
hazelwiss
reviewed
Dec 8, 2025
Contributor
hazelwiss
left a comment
hazelwiss
left a comment
There was a problem hiding this comment.
So, I just want to highlight some stuff about this that could probably need clarification in this PR.
Firstly, in the example I write
1 = 5
a = 1
a is not presumably 1 and not 5, so maybe numeric identifiers should be prefixed by something to better clarify what they are? By what discussion is raw numbers as identifiers acceptable?
Do these identifiers also play into paths? So a::2::b is a possible path?
Can they be used with generics? 2<T>?
I think if these points are further clarified and motivated it makes sense to merge this, maybe even as is.
hazelwiss
approved these changes
Dec 8, 2025
Contributor
hazelwiss
left a comment
hazelwiss
left a comment
There was a problem hiding this comment.
This was discussed on Discord. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.