Merged
Conversation
…reference value to its underlying type.
hazelwiss
commented
Oct 23, 2025
| } | ||
|
|
||
| #[test] | ||
| fn test_complex_flatten() { |
Contributor
Author
There was a problem hiding this comment.
This test did not work with my changes, however, I realized it was relying on the copy feature. Which is a broken feature and is underway to be removed. This does not affect the main codebase and it seemed safe to remove this test.
hazelwiss
commented
Oct 23, 2025
hazelwiss
commented
Oct 23, 2025
hazelwiss
commented
Oct 23, 2025
| /// | ||
| /// Constructs a builtin type. A builtin type is a type which is not constructed by Bauble during parsing and | ||
| /// might warrant additional rules. | ||
| fn builtin(#[expect(unused)] registry: &mut types::TypeRegistry) -> Option<TypeId> { |
Contributor
Author
There was a problem hiding this comment.
I needed to add builtin types to avoid construct_type for Ref<T>
Imberflur
reviewed
Oct 24, 2025
Contributor
Imberflur
left a comment
Imberflur
left a comment
There was a problem hiding this comment.
Here are my notes so far! I did not finish the review entirely but I believe these will be useful to have earlier.
Imberflur
reviewed
Oct 27, 2025
Imberflur
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where explicitly typed references did not delay registering properly. It also adds a usable
Ref<T>type in Bauble represented in Rust for use in tests.