Enforce explicit accessor pattern across core APIs (remove macro/inline accessors)#20
Open
Copilot wants to merge 15 commits into
Open
Enforce explicit accessor pattern across core APIs (remove macro/inline accessors)#20Copilot wants to merge 15 commits into
Copilot wants to merge 15 commits into
Conversation
Copilot
AI
changed the title
[WIP] Refactor getter and edit methods for read-only and editable access
Refactor pointer accessors into readonly/edit API pairs
May 25, 2026
Copilot
AI
changed the title
Refactor pointer accessors into readonly/edit API pairs
Standardize inline accessor macros and rename mutable query APIs to May 25, 2026
take_*
Cadons
requested changes
May 25, 2026
Cadons
approved these changes
May 25, 2026
Contributor
Author
Applied in |
Copilot
AI
changed the title
Standardize inline accessor macros and rename mutable query APIs to
Standardize inline accessor macros and align query API naming (May 25, 2026
take_*take_*/find_*)
Copilot
AI
changed the title
Standardize inline accessor macros and align query API naming (
Unify accessor generation into a single macro and fix API doc parser breakage
May 25, 2026
take_*/find_*)
Copilot
AI
changed the title
Unify accessor generation into a single macro and fix API doc parser breakage
Refactor accessor API: replace macro-generated getters/editors with explicit cpp methods
May 26, 2026
Copilot
AI
changed the title
Refactor accessor API: replace macro-generated getters/editors with explicit cpp methods
Enforce explicit accessor pattern across core APIs (remove macro/inline accessors)
May 26, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This change aligns the codebase with the requested accessor pattern: getters and
edit_*methods are now explicit class methods implemented in.ccfiles, avoiding macro-generated and inline accessor bodies.A full audit found one remaining non-conforming class, which is now refactored to match the same convention used in
DocraftDocument,DocraftDocumentContext, and the parser API.Pattern consolidation
docraft_lib.h.Core API alignment
DocraftDocument,DocraftDocumentContext, andDocraftCraftLanguageParsernow expose explicit accessor declarations in headers with implementations in corresponding.ccfiles.Codebase-wide completion
DocraftDocumentMetadatato remove inline accessor/setter/clear bodies from the header.docraft_document_metadata.ccand moved all method implementations there.Example of the applied pattern: