feat(dns): add DHCP automatic indicator and reset-to-DHCP#206
Open
awlx wants to merge 1 commit intoCachyOS:developfrom
Open
feat(dns): add DHCP automatic indicator and reset-to-DHCP#206awlx wants to merge 1 commit intoCachyOS:developfrom
awlx wants to merge 1 commit intoCachyOS:developfrom
Conversation
Add a 'DHCP (automatic)' entry to the DNS server dropdown so users can clearly see when no custom DNS is configured. Selecting it and clicking Apply resets DNS to automatic (same as the Reset button). Changes: - Add 'DHCP (automatic)' as the last entry in the DNS server combo box - Show it as selected when no DNS servers are manually configured - Clicking Apply with DHCP selected calls reset_dns_server() - Reset button now jumps the combo to 'DHCP (automatic)' and unchecks DoT/DoH - Disable DoT/DoH checkboxes and latency buttons when DHCP is selected - Add dhcp-automatic i18n string to en locale Follow-up to CachyOS#200 (DoH support) as discussed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #200 (DoH support) as discussed.
What changed
DHCP (automatic) indicator
Reset behavior
i18n
dhcp-automaticstring to en localeTesting