-
Notifications
You must be signed in to change notification settings - Fork 54
Robustify pyside #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hosaka
merged 11 commits into
CabbageDevelopment:master
from
kristjanvalur:robustify-pyside
Sep 18, 2025
Merged
Robustify pyside #158
hosaka
merged 11 commits into
CabbageDevelopment:master
from
kristjanvalur:robustify-pyside
Sep 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
c0c8a3c to
21667b6
Compare
This was referenced Sep 3, 2025
Contributor
Author
|
It would appear that the Notifier implementation in _unix.py is not actually used, but I updated it to match the other never the less, in case it ever gets wired in. |
Collaborator
|
Hi @kristjanvalur, sorry about the delay. I went through your changes. We can probably improve the test coverage, but it's not critical. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runnint the unittests with PySide is sometimes prone to crashing (see #154)
This PR fixes the issues by making lifetime management more robust.
app, for lifetime management.appfor lifetime managementEventPolleris stopped..deleteLater()for tidyness in case the __app lives on