Skip to content

Resolves issue #1729, Ensures Secretariat organization audit entries store authority in the same array format as BaseOrg documents. #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david-rocca wants to merge 1 commit into
base: dev
Choose a base branch
from
+14 −2
Open

Resolves issue #1729, Ensures Secretariat organization audit entries store authority in the same array format as BaseOrg documents. #1826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/repositories/baseOrgRepository.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,8 +595,6 @@ class BaseOrgRepository extends BaseRepository {
// Write - use org type specific model
if (registryObjectRaw.authority.includes('SECRETARIAT')) {
// Write
// testing:
registryObjectRaw.authority = 'SECRETARIAT'
const SecretariatObjectToSave = new SecretariatOrgModel(registryObjectRaw)
if (isSecretariat) {
registryObject = await SecretariatObjectToSave.save(options)
Expand Down
14 changes: 14 additions & 0 deletions test/integration-tests/audit/registryOrgCreatesAuditTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,20 @@ describe('Create and Update Audit Collection with Org Endpoints', () => {
expect(auditObject.UUID).to.equal(org.uuid)
})

it('Should keep Secretariat audit authority consistent with stored org authority', async () => {
const org = await createTestOrg({
authority: ['SECRETARIAT']
})

const auditRes = await chai.request(app)
.get(`/api/audit/org/${org.uuid}`)
.set(constants.headers)

expect(auditRes).to.have.status(200)
expect(auditRes.body.history).to.be.an('array').with.lengthOf(1)
expect(auditRes.body.history[0].audit_object.authority).to.deep.equal(['SECRETARIAT'])
})

it('Should create separate audit documents for multiple orgs', async () => {
// Create multiple orgs
const [org1, org2, org3] = await Promise.all([
Expand Down
Loading