[CBRD-26477] Implement LOB file move instead of copy during INSERT by InChiJun · Pull Request #6886 · CUBRID/cubrid

InChiJun · 2026-03-03T07:11:14Z

http://jira.cubrid.org/browse/CBRD-26477

Purpose

#6833 이후 서브 이슈로 진행되는 PR입니다.

LOB 데이터 삽입 시 temp file을 copy하지 않고 move 하도록 합니다.

특수 케이스(UPDATE)에서는 copy를 수행합니다.(특수 케이스에 대한 설명은 이슈 description 참고하시면 됩니다.)

Implementation

#6833 의 구현은 db_elo_copy_with_prefix() ~> xes_posix_copy_file_with_prefix() 로 수행되는 콜스택 하나만 존재했습니다.
이 PR에서는 elo_copy_with_prefix() 함수를 수정하여 STATE에 따라 move/copy 동작으로 분기하도록 구현하였습니다.

AS-IS

-> STATE에 상관 없이 copy 동작만 수행

TO-BE

-> STATE에 따라 다른 동작(각 STATE의 상황은 이슈 description을 참고하시면 됩니다.)

LOB_TRANSIENT_CREATED / LOB_PERMANENT_DELETED -> move file 수행
LOB_PERMANENT_CREATED / LOB_NOT_FOUND -> copy file 수행

Remarks

이 PR의 core를 담당하는 db_elo_copy_with_prefix() 함수 외에 다른 함수도 수정되었습니다.

지난 PR에서 commit 순서가 꼬여서 반영되지 않은 코드를 반영하였습니다.
추가로 리팩토링이 필요한 부분은 리팩토링을 수행하였습니다.

slob_remove_dir()
-> 반영되지 않은 commit 반영

lob_process_dir_add_attr()
-> 함수명 변경
-> 로직 변경 (lob_attrid_arr_length는 2 이하일 가능성이 높기 때문에, 조건문 순서를 우선으로 변경)
-> 코드 가독성 (중복된 for문을 한 곳에서 수행하도록 변경)

lob_process_dir_drop_attr()
-> 함수명 변경

locator_lob_process_dir()
-> 로직 변경 (lob_attrid_arr_length는 2 이하일 가능성이 높기 때문에, 조건문 순서를 우선으로 변경)
-> 코드 가독성 (중복된 for문을 한 곳에서 수행하도록 변경)

…ion call

…sary variable

InChiJun · 2026-03-03T07:38:14Z

/run all

InChiJun · 2026-03-03T07:58:42Z

/run all

InChiJun · 2026-03-03T09:45:07Z

/run all

InChiJun · 2026-03-03T23:16:45Z

참고

shell 테스트 실패 항목은 로컬에서 수행해보았고, 통과하였습니다.
code-style의 경우 제가 수정하지 않은 곳에서 발생하고 있어서, 리뷰 후에 반영하는 것으로 하겠습니다.

github-actions · 2026-03-24T05:00:50Z

🗑️ TC Branch Finalized for cubrid-testcases-private-ex

Engine PR was closed (not merged).

Cleanup Results:

TC develop branch is ready for the next PR.

github-actions · 2026-03-24T05:00:51Z

🗑️ TC Branch Finalized for cubrid-testcases

Engine PR was closed (not merged).

Cleanup Results:

TC develop branch is ready for the next PR.

github-actions · 2026-03-24T05:02:03Z

🧪 TC Test Environment Ready

CircleCI Testing:

CircleCI will automatically test using the branches below.

TC Repositories & Branches:

cubrid-testcases Draft PR (Branch: tc/pr-6886)
cubrid-testcases-private-ex Draft PR (Branch: tc/pr-6886)

Next Steps:

Wait for CircleCI tests to complete
If CircleCI tests failed, please check the test results and fix the issues.
When ready to merge this PR, please merge the TC PR first, then merge this PR.

greptile-apps · 2026-03-24T05:10:47Z

_{Reviews (24): Last reviewed commit: "Merge remote-tracking branch 'upstream/d..." | Re-trigger Greptile}

InChiJun · 2026-03-24T05:12:12Z

/run all

greptile-apps · 2026-03-26T15:01:36Z

_{Reviews (25): Last reviewed commit: "refactor slob_*_dir()" | Re-trigger Greptile}

greptile-apps · 2026-03-26T15:26:50Z

Important Files Changed

Filename	Overview
src/communication/network_interface_sr.cpp	slob_create_dir에서 or_unpack_int 결과를 null 체크 없이 or_unpack_int_array에 직접 체이닝하는 NPE 위험 존재. slob_remove_dir 단순화는 이전 스레드 결정과 일관성 있으나 create_dir는 체이닝 구조로 질적으로 다름.
src/object/elo.c	elo_copy_with_prefix가 LOB 상태에 따라 move/copy로 분기하도록 재구현됨. 이전 리뷰 피드백(real_locator 사용, er_set, es_delete_file 정리 등)이 대부분 반영되어 구현 품질이 개선됨.
src/storage/es_posix.c	xes_posix_move_file_with_prefix 신규 함수 추가. 이전 리뷰 피드백(er_set_with_oserror, snprintf truncation 검사, 로그 메시지 수정 등)이 모두 반영됨.
src/storage/es.c	es_move_file_with_prefix 신규 함수 추가 및 es_rename_file 로그 메시지 수정. 이전 리뷰 피드백이 정확히 반영됨.
src/transaction/locator_cl.c	locator_lob_create_or_remove_dir 리팩토링으로 truncate 케이스에서 중복 lob_remove_dir 호출 제거. locator_remove_class에서 lob_attrid_arr_length=0→1 버그 수정.
src/query/execute_schema.c	lob_process_dir_drop_attr에서 lob_attrid_arr_length=0→1 버그 수정, malloc 실패 시 er_set 추가. 중복 for-loop 통합으로 가독성 개선.

_{Reviews (28): Last reviewed commit: "Remove unnecessary call assert()" | Re-trigger Greptile}

InChiJun · 2026-03-27T03:54:15Z

/run all

github-actions · 2026-03-27T08:30:06Z

✅ TC Branch Finalized for cubrid-testcases

Engine PR was merged.

Cleanup Results:

Draft PR #2550: [CBRD-26477] Draft: TC changes for PR CUBRID/cubrid#6886: Closed
Branch tc/pr-6886: Deleted

TC base branch is ready for the next PR.

github-actions · 2026-03-27T08:30:07Z

✅ TC Branch Finalized for cubrid-testcases-private-ex

Engine PR was merged.

Cleanup Results:

Draft PR #3086: [CBRD-26477] Draft: TC changes for PR CUBRID/cubrid#6886: Closed
Branch tc/pr-6886: Deleted

TC base branch is ready for the next PR.

…py during INSERT (CUBRID#6886)

…UBRID#6886) http://jira.cubrid.org/browse/CBRD-26477 Modified LOB data insertion to perform a move operation rather than a copy operation.

InChiJun added 11 commits February 22, 2026 23:45

Modify develop copy_file -> move_file

74469db

remove copy_file_with_prefix keyword

43e0141

refactor code style

ab14474

refactor slob_remove_dir()

e38e90a

refactor sm_truncate_using_destroy_heap() -> remove unnecessary funct…

947dd1d

…ion call

refactor lob_process_dir_*_attr() -> rename function, refactor logic

8f54c7c

refactor heap_attrinfo_transform_variable_to_disk() -> remove unneces…

9c64dee

…sary variable

refactor locator_create_heap_if_needed()

a632591

rename function *elo_move_*() -> *elo_copy_*()

454d340

Add elo_copy_with_prefix() function

02a6bc9

Add elo_move_with_prefix() function

bd00b6e

InChiJun self-assigned this Mar 3, 2026

InChiJun marked this pull request as ready for review March 3, 2026 07:37

InChiJun requested review from beyondykk9 and hornetmj as code owners March 3, 2026 07:37

InChiJun removed the request for review from beyondykk9 March 3, 2026 07:37

refactor code style

dc97d3d

InChiJun added 3 commits March 3, 2026 09:10

Modify comment

1937c14

Merge remote-tracking branch 'upstream/develop' into CBRD-26477

458fd41

refactor code style

41daa14

InChiJun requested review from H2SU, YeunjunLee, hgryoo, hyahong, vimkim and youngjun9072 March 5, 2026 01:41

InChiJun reopened this Mar 24, 2026

cubrid-tc-sync-bot Bot mentioned this pull request Mar 24, 2026

[CBRD-26477] Draft: TC changes for PR CUBRID/cubrid#6886 CUBRID/cubrid-testcases#2550

Closed

YeunjunLee approved these changes Mar 24, 2026

View reviewed changes

hornetmj reviewed Mar 24, 2026

View reviewed changes

refactor slob_*_dir()

b2b634b

InChiJun added 6 commits March 26, 2026 15:01

refactor locator_cl.c

1ab43e5

Add er_set() in locator_lob_process_dir()

df0c682

refactor lob_process_dir_add_attr()

b834f36

Add er_set() in lob_process_dir_add_attr()

42681be

refactor code style

309bd21

Remove error handling when or_pack_int() return NULL

726b5b2

InChiJun added 3 commits March 26, 2026 15:39

Add er_set_with_oserror() when occur error in snprintf()

66ff780

Add return_error_to_client() to error handling

5542ca5

Remove unnecessary call assert()

b98fdda

hornetmj approved these changes Mar 27, 2026

View reviewed changes

Comment thread src/storage/es_posix.c

InChiJun merged commit 4a7c670 into CUBRID:develop Mar 27, 2026
12 checks passed

hyunikn added a commit to hyunikn/cubrid that referenced this pull request Mar 27, 2026

for commit 4a7c670 [CBRD-26477] Implement LOB file move instead of co…

35669ca

…py during INSERT (CUBRID#6886)

hyunikn added a commit to hyunikn/cubrid that referenced this pull request Mar 27, 2026

for commit 4a7c670 [CBRD-26477] Implement LOB file move instead of co…

3361dfc

…py during INSERT (CUBRID#6886)

Conversation

InChiJun commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Implementation

AS-IS

TO-BE

Remarks

Uh oh!

InChiJun commented Mar 3, 2026

Uh oh!

InChiJun commented Mar 3, 2026

Uh oh!

InChiJun commented Mar 3, 2026

Uh oh!

InChiJun commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

github-actions Bot commented Mar 24, 2026

🧪 TC Test Environment Ready

Uh oh!

greptile-apps Bot commented Mar 24, 2026

Uh oh!

InChiJun commented Mar 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Mar 26, 2026

Uh oh!

greptile-apps Bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Important Files Changed

Uh oh!

Uh oh!

InChiJun commented Mar 27, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

InChiJun commented Mar 3, 2026 •

edited

Loading

InChiJun commented Mar 3, 2026 •

edited

Loading

greptile-apps Bot commented Mar 26, 2026 •

edited

Loading