Skip to content

feat: AcceptInfoResponseDTO 응답 포맷을 config-server 명세에 맞게 수정#255

Merged
dongmin0204 merged 1 commit into
developfrom
feat/#254-accept-info-format-fix
Jul 6, 2026
Merged

feat: AcceptInfoResponseDTO 응답 포맷을 config-server 명세에 맞게 수정#255
dongmin0204 merged 1 commit into
developfrom
feat/#254-accept-info-format-fix

Conversation

@yoon6yo

@yoon6yo yoon6yo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

요약

변경 내용

AcceptInfoResponseDTO

항목 변경 전 변경 후
그룹 정보 gid: [Long] groups: [{gid, name}]
GPU/노드 정보 gpu_required: true gpu_nodes: [{node_name, num_gpu, cpu_limit, memory_limit}]

ConfigRequestService

  • NodeRepository 주입 추가
  • getAcceptInfo()@Transactional(readOnly = true) 추가
  • Request의 ResourceGroup에 속한 Node 목록 조회 후 DTO에 전달

변환 규칙

  • cpu_limit: cpuCoreCount * 1000 + "m" (예: 4코어 → "4000m")
  • memory_limit: memorySizeGB * 1024 + "Mi" (예: 8GB → "8192Mi")

테스트 계획

  • groups 필드 GID + 그룹명 포함 확인
  • gpu_nodes 필드 k8s 포맷 변환 확인 (cpu_limit, memory_limit)
  • additional_ports 기존 동작 유지 확인
  • config-server와 실제 연동 테스트

- gid 숫자 배열 → groups [{gid, name}] 객체 배열로 교체
- gpu_required bool → gpu_nodes [{node_name, num_gpu, cpu_limit, memory_limit}] 로 교체
- ConfigRequestService에 NodeRepository 주입 및 노드 조회 로직 추가
- cpu_limit: cpuCoreCount * 1000 + "m", memory_limit: memorySizeGB * 1024 + "Mi" 변환
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 86be3f3b-a3e5-413f-b91f-3b3d2d5dcf65

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/#254-accept-info-format-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dongmin0204 dongmin0204 merged commit 8ec3fe9 into develop Jul 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AcceptInfoResponseDTO 응답 포맷을 config-server 명세에 맞게 수정

2 participants