fix: 관리자 API 권한 체크 활성화 및 Redis 리프레시 토큰 TTL 단위 수정#250
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
변경 사항
[C-1] SecurityConfig.java — 관리자 API 권한 체크 활성화
주석 처리되어 있던
/api/admin/**경로의 ADMIN 롤 체크를 활성화합니다.일반 USER 토큰으로 관리자 API 호출이 가능했던 보안 취약점을 제거합니다.
[C-2] TokenService.java — Redis TTL 단위 수정
application.yml의refresh-token-expire-time: 604800000값은 밀리초(7일) 기준입니다.TimeUnit.SECONDS로 처리하면 약 19.2년이 되는 버그를TimeUnit.MILLISECONDS로 수정합니다.테스트
./gradlew test)🤖 Generated with Claude Code