added m2m example + readme #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaartendeKruijf
requested changes
Dec 11, 2024
Contributor
MaartendeKruijf
left a comment
MaartendeKruijf
left a comment
There was a problem hiding this comment.
Add a build action to the CI look good
MaartendeKruijf
requested changes
Dec 11, 2024
Makefile
Outdated
Comment on lines
1
to
22
| .PHONY: test lint build dev | ||
| .DEFAULT_GOAL := dev | ||
|
|
||
| EXAMPLE_DIRS := $(shell find examples -name "go.mod" -exec dirname {} \;) | ||
|
|
||
| define generate_build_target | ||
| .PHONY: build-$(1) | ||
| build-$(1): | ||
| cd $(1) && go build ./... | ||
| endef | ||
|
|
||
|
|
||
| #for each a seperate build target | ||
| $(foreach dir,$(EXAMPLE_DIRS),$(eval $(call generate_build_target,$(dir)))) | ||
|
|
||
| # that is called here | ||
| build: $(patsubst %,build-%,$(EXAMPLE_DIRS)) | ||
|
|
Contributor
There was a problem hiding this comment.
Just make it explicit this is unreadable
|
|
||
|
|
||
| build: | ||
| name: Build project |
Makefile
Outdated
| EXAMPLE_DIRS := $(shell find examples -name "go.mod" -exec dirname {} \;) | ||
|
|
||
| define generate_build_target | ||
| .PHONY: build-$(1) |
Contributor
There was a problem hiding this comment.
You are overwriting your .PHONY here
RabbITCybErSeC
force-pushed
the
feature/10-add-m2m-token-obtain-example
branch
from
3e66c50 to
a75657c
Compare
MaartendeKruijf
approved these changes
Dec 19, 2024
MaartendeKruijf
force-pushed
the
feature/10-add-m2m-token-obtain-example
branch
from
cb1221f to
954daed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.