Feature/docs/332 kms key auth #364
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes 06b0473: this commit did indeed fix the issue at hand, but also inadvertently broke the swagger generation. This also adds the entries for the manual api, which were apparently missing.
This is currently listed under extensions & capabilities. The kms is a cacao-native feature in that the json entries are from the cacao spec, but the actual implementation beyond this is not specified. It therefore makes sense to put it here and not as a core component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds documentation for feature #363
There are also fixes the swagger command from #362 , and adds api documentation for the manual capability which was written but not applied in the docs.
The page about the KMS is under extensions & capabilities. The KMS is a feature of the cacao spec, but the implementation is not defined and therefore closer to an extension.