Skip to content

Conversation

@mpboom
Copy link
Collaborator

@mpboom mpboom commented Jan 31, 2025

Related to #320 (part 2/2)

@mpboom
Copy link
Collaborator Author

mpboom commented Jan 31, 2025

daw1012345@a42dec7

@github-actions
Copy link

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.8 stars

Show details

Sigrid compared your code against the baseline of 2025-01-28.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 897 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Duplication
(Introduced)
pkg/core/capability/caldera/api/models/agent.go (lines 25-116)
pkg/core/capability/caldera/api/models/partial_agent.go (lines 25-116)
🔴 Duplication
(Introduced)
pkg/core/capability/caldera/api/client/payloads/get_api_v2_payloads_parameters.go (lines 181-240)
pkg/core/capability/caldera/api/client/payloads/head_api_v2_payloads_parameters.go (lines 181-240)
🔴 Duplication
(Introduced)
pkg/core/capability/caldera/api/client/facts/head_api_v2_facts_operation_id_parameters.go (line 178-230)
pkg/core/capability/caldera/api/client/facts/get_api_v2_facts_operation_id_parameters.go (line 178-230)
pkg/core/capability/caldera/api/client/relationships/head_api_v2_relationships_operation_id_parameters.go (line 178-230)
+ 1 occurrences
🔴 Duplication
(Introduced)
pkg/core/capability/caldera/api/client/operationsops/head_api_v2_operations_id_potential_links_parameters.go (line 181-233)
pkg/core/capability/caldera/api/client/operationsops/get_api_v2_operations_id_potential_links_parameters.go (line 181-233)
pkg/core/capability/caldera/api/client/operationsops/head_api_v2_operations_id_links_parameters.go (line 178-230)
+ 1 occurrences
🔴 Duplication
(Introduced)
pkg/core/capability/caldera/api/models/link.go (lines 24-93)
pkg/core/capability/caldera/api/models/partial_link.go (lines 24-93)
🔴 Duplication
(Introduced)
pkg/core/capability/caldera/api/client/objectives/get_api_v2_objectives_parameters.go (line 164-211)
pkg/core/capability/caldera/api/client/plugins/head_api_v2_plugins_parameters.go (line 164-211)
pkg/core/capability/caldera/api/client/adversaries/get_api_v2_adversaries_parameters.go (line 164-211)
+ 23 occurrences
🔴 Duplication
(Introduced)
pkg/core/capability/caldera/api/client/operationsops/post_api_v2_operations_id_event_logs_parameters.go (lines 180-220)
pkg/core/capability/caldera/api/client/operationsops/post_api_v2_operations_id_report_parameters.go (lines 180-220)
🔴 Duplication
(Introduced)
pkg/core/capability/caldera/api/client/operationsops/get_api_v2_operations_id_links_link_id_result_parameters.go (line 184-224)
pkg/core/capability/caldera/api/client/operationsops/get_api_v2_operations_id_links_link_id_parameters.go (line 184-224)
pkg/core/capability/caldera/api/client/operationsops/head_api_v2_operations_id_links_link_id_parameters.go (line 184-224)
+ 1 occurrences
⚫️ + 889 more

📚 Remaining technical debt

0 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid** to explore your technical debt

⭐️ Sigrid ratings

System property System on 2025-01-28 Before changes New/changed code
Volume 5.4 N/A N/A
Duplication 4.4 N/A 1.8
Unit Size 2.6 N/A 4.1
Unit Complexity 3.0 N/A 3.5
Unit Interfacing 3.1 N/A 4.7
Module Coupling 3.8 N/A 5.5
Component Independence 0.5 N/A N/A
Component Entanglement 2.5 N/A N/A
Maintainability 3.2 N/A 4.0

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants