added compilation symbols #219
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
RabbITCybErSeC
changed the title
makefile
Outdated
| VERSION = $(shell git describe --tags --dirty) | ||
| BUILDTIME := $(shell date '+%Y-%m-%dT%T%z') | ||
|
|
||
| GOLDFLAGS += -s -w |
Collaborator
There was a problem hiding this comment.
I think these only should be used for production builds
MaartendeKruijf
requested changes
Sep 5, 2024
Collaborator
MaartendeKruijf
left a comment
MaartendeKruijf
left a comment
There was a problem hiding this comment.
Update to only use in production builds as this will hamper the ability to debug
MaartendeKruijf
force-pushed
the
feature/218-fix-build-flags
branch
from
034d10d to
eaba4e0
Compare
Sigrid maintainability feedback💭️ You did not change any files that are measured by Sigrid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.com/questions/22267189/what-does-the-w-flag-mean-when-passed-in-via-the-ldflags-option-to-the-go-comman