Use cosmic-settings.json to perform error checks on BSEDict#740
Use cosmic-settings.json to perform error checks on BSEDict#740TomWagg merged 30 commits intoCOSMIC-PopSynth:developfrom
cosmic-settings.json to perform error checks on BSEDict#740Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #740 +/- ##
===========================================
- Coverage 86.91% 78.67% -8.24%
===========================================
Files 40 49 +9
Lines 25542 27132 +1590
Branches 0 908 +908
===========================================
- Hits 22198 21345 -853
- Misses 3344 5514 +2170
- Partials 0 273 +273 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
version bump for cosmic and python version add up to 3.14 and remove 3.9
github-actions
Bot
added
the
needs-cmc-review
|
🚨 CMC review requested This pull request modifies one or more of the following files:
A CMC developer should review this PR to ensure corresponding changes are propagated upstream as needed. |
|
🚨 CMC review requested This pull request modifies one or more of the following files:
A CMC developer should review this PR to ensure corresponding changes are propagated upstream as needed. |
|
🚨 CMC review requested This pull request modifies one or more of the following files:
A CMC developer should review this PR to ensure corresponding changes are propagated upstream as needed. |
|
🚨 CMC review requested This pull request modifies one or more of the following files:
A CMC developer should review this PR to ensure corresponding changes are propagated upstream as needed. |
|
🚨 CMC review requested This pull request modifies one or more of the following files:
A CMC developer should review this PR to ensure corresponding changes are propagated upstream as needed. |
hail mary from gpt with versioning
|
🚨 CMC review requested This pull request modifies one or more of the following files:
A CMC developer should review this PR to ensure corresponding changes are propagated upstream as needed. |
|
🚨 CMC review requested This pull request modifies one or more of the following files:
A CMC developer should review this PR to ensure corresponding changes are propagated upstream as needed. |
…-PopSynth#740) * move cosmic-settings.json, clearer valid values * add data in meson build * overhaul error_check to use the json * add explain_setting function * update __all__ * condition was reversed * lists are not okay * need to let it ecsn_mlow be 0.0 * add empty init to avoid being a namespace package * change import based on python version * version bump for cosmic and python version add up to 3.14 and remove 3.9 * ensure setuptools is up to date * remove extra line * hail mary from gpt with versioning * bad comma * removing importlib-metadata since it allegedly is only needed for <3.8 * removing 3.14 * adding back in importlib-metadata for linting * avoid inserting one column at a time, use concat, avoid warning * remove importlib-metadata * update flake8 install * use concat for kicks too * axe flake8, who needs linting anyway? * remove flake8 here too --------- Co-authored-by: Katie Breivik <kbreivik@andrew.cmu.edu>
2 participants
This PR changes the
error_checkfunction from a gargantuan collection of if statements to a loop based on the settings JSON file. The valid values are based off the options listed in the JSON file. These values can beA value is defined as valid if it matches one of the values/ranges listed in the settings.
Exceptions are the array settings, those I left manually as exceptions.
Separately, I also created a
cosmic.utils.explain_settingfunction, which queries the JSON for the setting and prints out its description as well as all of the valid options, what they mean, and which one is the COSMIC default choice.e.g.
gives
Closes #737