Make hipCUB dependency private #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with HIP, there is a hipCUB dependency. For reasons, you cannot load the library directly. Instead, we add the include directories to the library. These were declared public, but other projects importing the library would not necessarily have these dependent libraries. Thus, declare them private. They should only be needed when compiling the MGARD library.
Contributor
Author
|
@JieyangChen7 Can you review this change? |
Collaborator
|
@kmorel, I lost track of the current status of the issue related to MGARD, HIP, and Spack. Since this PR is related, should I merge this PR now? |
Contributor
Author
|
Yeah, I forgot about this until you reminded me. Too many PRs in too many places. Yes, this is still necessary. It is part of spack/spack-packages#44, which assumes this will be changed by the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with HIP, there is a hipCUB dependency. For reasons, you cannot load the library directly. Instead, we add the include directories to the library. These were declared public, but other projects importing the library would not necessarily have these dependent libraries. Thus, declare them private. They should only be needed when compiling the MGARD library.