Merged
Conversation
docs: Updating html doc with cli --help output
refactor: cleaned code
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
guillaumeeb
reviewed
May 19, 2025
Member
guillaumeeb
left a comment
guillaumeeb
left a comment
There was a problem hiding this comment.
Just one question on the init.py file
src/eolab/georastertools/__init__.py
Outdated
| # import the method to run a rastertool | ||
| from eolab.georastertools.main import georastertools, add_custom_rastertypes | ||
|
|
||
| if not os.environ.get('READTHEDOCS', False): |
Member
There was a problem hiding this comment.
It's a bit weird to me to have a READTHEDOC if statement in main code.
Collaborator
Author
There was a problem hiding this comment.
I found an alternative to not use the READTHEDOCS variable in the main code. I removed the if statement
guillaumeeb
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR contains the necessary files to push the documentation to ReadTheDocs.
The tutorial has also been updated.