Closed
Conversation
Collaborator
|
not a wolf |
jack-ryan-nava-pbc
added
Impacts: Medicare
jack-ryan-nava-pbc
requested changes
Mar 31, 2026
Collaborator
jack-ryan-nava-pbc
left a comment
jack-ryan-nava-pbc
left a comment
There was a problem hiding this comment.
Just want to take advantage of the translation functionality we have and to match the conventions of the other icon files.
| @@ -0,0 +1,30 @@ | |||
| import type * as React from 'react'; | |||
| import { SvgIcon } from '@cmsgov/design-system'; | |||
| import { IconCommonProps } from '@cmsgov/design-system'; | |||
Collaborator
There was a problem hiding this comment.
Can you make sure to import the t translation function?
|
|
||
| return ( | ||
| <span className="icon-wrapper"> | ||
| <SvgIcon {...defaultProps} {...props} className={iconCssClasses}> |
Collaborator
There was a problem hiding this comment.
Can you move the title prop out of the default props object and as a direct input to the SvgIcon component and translate it?
Contributor
Author
|
Commit history got messed up. Will redo with a fresh branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding a new icon that CXT uses within their application: apple
How to test
AppleIconChecklist
[CMSDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.If this is a change to design:
If this is a change to code:
npm run test:unitandnpm run test:browser:allwere each successfulnpm run test:unit:update) and browser-test snapshots (npm run test:browser:all:update)If this is a change to documentation/content: