Skip to content

Fix logging of asset count in impact calculation #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spjuhel merged 3 commits into from
Dec 18, 2025
+4 −2
Merged

Fix logging of asset count in impact calculation #1195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6e1a7f
Fix logging of asset count in impact calculation
spjuhel Dec 11, 2025
fca656f
Updates Changelog
spjuhel Dec 11, 2025
2b20784
Fixes the test that wasn't testing well
spjuhel Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ Code freeze date: YYYY-MM-DD

### Fixed

- Fixed asset count in impact logging message [#1195](https://github.com/CLIMADA-project/climada_python/pull/1195).

### Deprecated

### Removed
Expand Down
2 changes: 1 addition & 1 deletion climada/engine/impact_calc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def impact(
return self._return_empty(save_mat)
LOGGER.info(
"Calculating impact for %s assets (>0) and %s events.",
exp_gdf.size,
len(exp_gdf),
self.n_events,
)
imp_mat_gen = self.imp_mat_gen(exp_gdf, impf_col)
Expand Down
2 changes: 1 addition & 1 deletion climada/engine/test/test_impact_calc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ def test_calc_insured_impact_no_insurance(self):
self.assertEqual(
logs.output,
[
"INFO:climada.engine.impact_calc:Calculating impact for 150 assets (>0) and 14450 events."
"INFO:climada.engine.impact_calc:Calculating impact for 50 assets (>0) and 14450 events."
],
)
self.assertEqual(icalc.n_events, len(impact.at_event))
Expand Down
Loading