fix: culling issue with vertical slabs when using Sodium#345
Open
M4elstr0m wants to merge 1 commit intoCJMinecraft01:1.21.1from
Open
fix: culling issue with vertical slabs when using Sodium#345M4elstr0m wants to merge 1 commit intoCJMinecraft01:1.21.1from
M4elstr0m wants to merge 1 commit intoCJMinecraft01:1.21.1from
Conversation
The bug was only related to a variable name in prepareForBlock method: slabState -> state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is related to the Issue #344, please refer to it for more informations about the bug itself.
The bug was only related to a variable name in
prepareForBlockmethod:slabState -> state.I tested this fix by myself in my client.
~ @M4elstr0m