Implement pluggable fire-spotting models from CA comparison study#30
Draft
Copilot wants to merge 8 commits intospotting-probabilityfrom
Draft
Implement pluggable fire-spotting models from CA comparison study#30Copilot wants to merge 8 commits intospotting-probabilityfrom
Copilot wants to merge 8 commits intospotting-probabilityfrom
Conversation
- Add SpottingModel type with four models: alexandridis, trucchia, pereira, koo - Implement individual spotting distance functions for each model - Add get_spotting_fn() factory function similar to get_p_time_fn() - Update configuration to include spotting_model parameter - Thread spotting_fn through propagation chain - Update CLI to pass spotting_fn to Propagator Co-authored-by: Perello-nico <71607852+Perello-nico@users.noreply.github.com>
- Test all four spotting models (alexandridis, trucchia, pereira, koo) - Validate correct behavior with zero wind - Verify stochastic nature of models - Test wind direction and speed effects - Fix import statements in spotting functions for numba compatibility Co-authored-by: Perello-nico <71607852+Perello-nico@users.noreply.github.com>
- Add inline documentation in example_spotting_dynamics.py - Update programmatic guide with spotting model section - Document all four available models and their usage - Show both config-based and programmatic model selection Co-authored-by: Perello-nico <71607852+Perello-nico@users.noreply.github.com>
- Fix import order in configuration.py (pytz before numpy) - Improve error message in get_spotting_fn for consistency - Update test to match new error message Co-authored-by: Perello-nico <71607852+Perello-nico@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement and test spotting models from wildfire study
Implement pluggable fire-spotting models from CA comparison study
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds four spotting distance models (Alexandridis, Trucchia, Pereira, Koo) from the 2024 Agricultural and Forest Meteorology comparison study, following the existing ROS model selection architecture.
Implementation
functions.py, each with different physics (exponential, power-law, log-normal, flight-time based)get_spotting_fn()selector matchingget_p_time_fn()designspotting_fnparameter throughcompute_spotting()→single_cell_updates()→next_updates_fn()→advance_front_until()spotting_modelfield toPropagatorConfigurationLegacywith default "alexandridis"SpottingModelliteral type for compile-time validationUsage
Configuration-based:
{ "do_spotting": true, "spotting_model": "trucchia" }Programmatic:
Testing
Added 13 tests covering factory behavior, model physics (zero wind, directional effects, stochastic behavior), and edge cases.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
astral.sh/usr/bin/curl curl -LsSf REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.