Add dump support for empty views#34
Draft
daxmawal wants to merge 2 commits into
Draft
Conversation
f70359c to
b14d82c
Compare
b14d82c to
a1dc0d8
Compare
Signed-off-by: daxmawal <jeanfrancoismanutea@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #25
There is also a draft proposed PR in Kokkos Core to fix this.
Fix overview
Before, the dump path trusted the size reported by the Kokkos allocation hook and used it as the number of bytes to copy from
p_data.That is unsafe because
p_datapoints to the user-data region after the Kokkos allocation header, while the reported size can be larger than the bytes that are actually available from that pointer.For a non-empty view, the layout looks like this:
For an empty view, p_data point at the end of the allocation:
The fix computes the real allocation bounds first, then validates the byte range before copying:
The dump now stores both values:
size: number of user-data bytes that are safe to copyreported_size: size reported by the Kokkos allocation hook